Fix req.txt, changed .py files to fit convention#1
Closed
zegevlier wants to merge 1 commit intoKeyAuth:mainfrom
zegevlier:main
Closed
Fix req.txt, changed .py files to fit convention#1zegevlier wants to merge 1 commit intoKeyAuth:mainfrom zegevlier:main
zegevlier wants to merge 1 commit intoKeyAuth:mainfrom
zegevlier:main
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the hardcoded and repeated keypath to a variable, I changed some variable names to fit with convention (starting with _ if the var is unused) and I fixed the requirements.txt, the lines shouldn't have commas on the end.
I'm also curious as to why you are ignoring ssl certificates when making a request to your server, it makes it a lot easier for someone to just edit their etc/hosts file and always respond with "KeyAuth_Valid".
Edit: Also please ignore my typo in the commit name