Merged
Conversation
Contributor
yxd-hde
commented
Nov 8, 2018
yxd-hde
commented
- Adjust context class
- Change process execution entry point
- Add aws_request_id to logger's context
Contributor
Author
|
This fixes #40 . And it changes the API signature of |
freedomofkeima
approved these changes
Nov 8, 2018
Collaborator
freedomofkeima
left a comment
freedomofkeima
left a comment
There was a problem hiding this comment.
LGTM.
Since it will break invocation to call (introduced in #35), it should be mentioned in release note.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.