Skip to content

Expand for-of loop support to iterable types#317

Merged
philippedistributive merged 2 commits intomainfrom
philippe/for-of-iterable
Apr 15, 2024
Merged

Expand for-of loop support to iterable types#317
philippedistributive merged 2 commits intomainfrom
philippe/for-of-iterable

Conversation

@philippedistributive
Copy link
Copy Markdown
Collaborator

@philippedistributive philippedistributive commented Apr 15, 2024 •
edited
Loading

for-of loop now works with the iterable type as well

zollqir
zollqir approved these changes Apr 15, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@zollqir zollqir left a comment •
edited by philippedistributive
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only failure is a known XHR test that needs to be changed as per #314

@philippedistributive philippedistributive merged commit c9bec0f into main Apr 15, 2024
@philippedistributive philippedistributive deleted the philippe/for-of-iterable branch April 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zollqir zollqir zollqir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philippedistributive @zollqir