Merged
Conversation
…tory-cleanup-dcp-client
…tory-cleanup-dcp-client
…tory-cleanup-dcp-client
… module to access other bootstrap modules, including those which are fully virtual
philippedistributive
changed the base branch from
main
to
philippe/pyTypeFactory-cleanup-dcp-client
philippedistributive
requested review from
Xmader,
philippedistributive and
zollqir
philippedistributive
changed the base branch from
philippe/pyTypeFactory-cleanup-dcp-client
to
philippe/pyTypeFactory-cleanup
…ub.com:Distributive-Network/PythonMonkey into wes/DCP-4054/make-dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
philippedistributive
requested review from
Xmader
and removed request for
zollqir
…dcp-client-grok-pythonmonkey
…dcp-client-grok-pythonmonkey
zollqir
force-pushed
the
philippe/pyTypeFactory-cleanup
branch
from
00cd684 to
a2d818a
Compare
…dcp-client-grok-pythonmonkey
Base automatically changed from
philippe/pyTypeFactory-cleanup
to
caleb/fix/this
April 3, 2024 19:03
zollqir
requested changes
Apr 4, 2024
Collaborator
zollqir
left a comment
zollqir
left a comment
There was a problem hiding this comment.
LGTM apart from one question for Wes
philippedistributive
approved these changes
Apr 4, 2024
philippedistributive
approved these changes
Apr 4, 2024
philippedistributive
approved these changes
Apr 4, 2024
philippedistributive
deleted the
wes/DCP-4054/make-dcp-client-grok-pythonmonkey
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch works well enough with dcp-client to launch a dcp job and receive results from the global compute group.
To use
cd dcp-client && build/bundle --dcp=../dcp --build=debug)There is also a ping.py in that directory which shows how to send a keepalive mesage to a dcp service.
This PR depends on PR 234 and PR 227