"contains" method for Object "in" operations added#188
Merged
Conversation
tp_as_sequence added
Collaborator
Author
|
Need to resolve conflict and failing test |
zollqir
requested changes
Nov 24, 2023
Collaborator
zollqir
left a comment
zollqir
left a comment
There was a problem hiding this comment.
Just a couple minor changes on the tests and I think its good to go
Comment on lines
+131
to
+132
| pm.eval("let obj = {'c':5}") | ||
| a = pm.eval('obj') |
Collaborator
There was a problem hiding this comment.
Suggested change
| pm.eval("let obj = {'c':5}") | |
| a = pm.eval('obj') | |
| a = pm.eval("({'c':5})") |
Collaborator
There was a problem hiding this comment.
This change would ensure that the object remains rooted as long as a exists, since as written the object will be permanently rooted since its declared and assigned at global scope.
Comment on lines
+136
to
+137
| pm.eval("let obj1 = {'c':5}") | ||
| a = pm.eval('obj1') |
Collaborator
There was a problem hiding this comment.
Suggested change
| pm.eval("let obj1 = {'c':5}") | |
| a = pm.eval('obj1') | |
| a = pm.eval("({'c':5})") |
Comment on lines
+141
to
+142
| pm.eval("let obj2 = {'c':5}") | ||
| a = pm.eval('obj2') |
Collaborator
There was a problem hiding this comment.
Suggested change
| pm.eval("let obj2 = {'c':5}") | |
| a = pm.eval('obj2') | |
| pm.eval("({'c':5})") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
now support the "in" operation for Dicts
cleanup unused method
fix memory leak
closes #187
Does not implement "in" for Lists yet. This is left to #186