Add phar build command for codeception 5.3#898
Add phar build command for codeception 5.3#898TavoNiievez merged 5 commits intoCodeception:masterfrom
Conversation
|
@W0rma I'm not familiar with the phar release management, but the readme might need some adjustment as well to include commands for the PHP 8.2/Codeception 5.3 release: codeception.github.com/package/README.md Line 24 in dc29cb9 |
You are right. I adjusted the file. |
package/README.md
Outdated
| 2. Run `./vendor/bin/robo release80` | ||
| 5. Commit added files and push | ||
| 5. Build Codeception 5.3 phar file | ||
| 1. Run `./vendor/bin/robo build:phar82` |
There was a problem hiding this comment.
Why did you decide to keep the command for PHP 8.0?
There was a problem hiding this comment.
There's no specific reason. I just noticed that the other commands for older versions are still listed, too.
There was a problem hiding this comment.
An outdated logic that I believe we should not maintain.
There was a problem hiding this comment.
I removed the phar build commands for codeception < 5.3
RoboFile.php
Outdated
| const REPO_BLOB_URL = 'https://github.com/Codeception/Codeception/blob'; | ||
| const BRANCH_4x = '4.2'; | ||
| const BRANCH_5x = '5.1'; | ||
| const BRANCH_53 = '5.3'; |
There was a problem hiding this comment.
Almost perfect.
The only detail is that this constant makes more sense if it continues to be named 5X and only its value changes
There was a problem hiding this comment.
I have renamed the constant
3 participants
This PR adds the commands
build:phar82andrelease82as proposed in Codeception/Codeception#6864 (comment)