This repository was archived by the owner on Jul 27, 2024. It is now read-only.
Added PDF conversion capabilities and simplified conversion script#17
Closed
InputObject2 wants to merge 1 commit intoBookStackApp:mainfrom
Closed
Added PDF conversion capabilities and simplified conversion script#17InputObject2 wants to merge 1 commit intoBookStackApp:mainfrom
InputObject2 wants to merge 1 commit intoBookStackApp:mainfrom
Conversation
Member
|
Thanks for offering these changes @InputObject2 but I'm not really looking to increase the scope or functionality of these scripts much wider to keep maintenance reasonable, they're really here to provide some simple starting points or examples for various scenarios. Feel free though to extract your more developed work into it's own repository for it to then be added to the "Community Projects & Scripts" list in the project readme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ended up reworking the original script quite a bit since I wanted to put the different functions on their own to simplify adding more parsers in the future if needed.
I also added a java check since pdf2html requires java to be in the path to be able to run the .jar for conversion.
There's also some logging on import.
I'm planning to add another modification to this script to parse a folder (if that's what is provided instead of a file name) and upload all the supported files it finds in it.