Chemical mask implementation#504
Open
SreejithNREL wants to merge 8 commits intoAMReX-Combustion:developmentfrom
Open
Chemical mask implementation#504SreejithNREL wants to merge 8 commits intoAMReX-Combustion:developmentfrom
SreejithNREL wants to merge 8 commits intoAMReX-Combustion:developmentfrom
Conversation
Checking if formatting passes
Contributor
|
Let's ignore codespell for now. We need to fix that in a different PR. |
hsitaram
reviewed
May 28, 2024
Contributor
hsitaram
left a comment
hsitaram
left a comment
There was a problem hiding this comment.
I am a bit worried though, shouldn't the states be updated with the adv/diffusion sources * dt before being sent back to the application codes (LM/C)?
marchdf
requested changes
May 28, 2024
| amrex::Array4<amrex::Real> const& rhoE, | ||
| amrex::Array4<amrex::Real> const& frcEExt, | ||
| amrex::Array4<amrex::Real> const& FC_in, | ||
| amrex::Array4<int> const& mask, |
Contributor
There was a problem hiding this comment.
the mask should probably come in as amrex::Array4<const int> const&
| amrex::Array4<amrex::Real> const& rEner_src_in, | ||
| amrex::Array4<amrex::Real> const& FC_in, | ||
| amrex::Array4<int> const& /*mask*/, | ||
| amrex::Array4<int> const& mask, |
| rYsrc_ext[sp] = rYsrc_in(i, j, k, sp); | ||
| } | ||
|
|
||
| int nsteps = 0; |
Contributor
There was a problem hiding this comment.
did anything happen here beyond just a big indent because of the if condition?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chemistry mask implementation.
Updated Arkode, Cvode, RK64, and BDF chem integrators to mask chemical reactions inside a user-specified box region. Verified code change on PMF case for Clang serial, MPI, CUDA, and HIP.