Move delegation of __ne__ to __eq__ out of objobject

Author: OddCoincidence

tests/snippets/object.py

@@ -0,0 +1,11 @@
+class MyObject:
+    pass
+
+assert not MyObject() == MyObject()
+assert MyObject() != MyObject()
+myobj = MyObject()
+assert myobj == myobj
+assert not myobj != myobj
+
+assert MyObject().__eq__(MyObject()) == NotImplemented
+assert MyObject().__ne__(MyObject()) == NotImplemented

vm/src/obj/objobject.rs

@@ -3,7 +3,6 @@ use super::super::pyobject::{
     TypeProtocol,
 };
 use super::super::vm::VirtualMachine;
-use super::objbool;
 use super::objstr;
 use super::objtype;
 use std::cell::RefCell;
@@ -29,20 +28,19 @@ fn object_eq(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
     arg_check!(
         vm,
         args,
-        required = [(zelf, Some(vm.ctx.object())), (other, None)]
+        required = [(_zelf, Some(vm.ctx.object())), (_other, None)]
     );
-    Ok(vm.ctx.new_bool(zelf.is(other)))
+    Ok(vm.ctx.not_implemented())
 }
 
 fn object_ne(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {
     arg_check!(
         vm,
         args,
-        required = [(zelf, Some(vm.ctx.object())), (other, None)]
+        required = [(_zelf, Some(vm.ctx.object())), (_other, None)]
     );
 
-    let eq = vm._eq(zelf.clone(), other.clone())?;
-    objbool::not(vm, &eq)
+    Ok(vm.ctx.not_implemented())
 }
 
 fn object_hash(vm: &mut VirtualMachine, args: PyFuncArgs) -> PyResult {

vm/src/vm.rs

@@ -13,6 +13,7 @@ use std::sync::{Mutex, MutexGuard};
 use super::builtins;
 use super::bytecode;
 use super::frame::Frame;
+use super::obj::objbool;
 use super::obj::objcode;
 use super::obj::objgenerator;
 use super::obj::objiter;
@@ -616,7 +617,8 @@ impl VirtualMachine {
 
     pub fn _ne(&mut self, a: PyObjectRef, b: PyObjectRef) -> PyResult {
         self.call_or_unsupported(a, b, "__ne__", "__ne__", |vm, a, b| {
-            Ok(vm.new_bool(!a.is(&b)))
+            let eq = vm._eq(a, b)?;
+            objbool::not(vm, &eq)
         })
     }