rename harcoded value to macro

Author: chobie

branch.c

@@ -191,7 +191,7 @@ PHP_FUNCTION(git_branch_lookup)
 PHP_FUNCTION(git_branch_name)
 {
 	php_git2_t *result = NULL;
-	char out[512] = {0};
+	char out[GIT2_BUFFER_SIZE] = {0};
 	zval *ref = NULL;
 	php_git2_t *_ref = NULL;
 	int error = 0;
@@ -242,8 +242,8 @@ PHP_FUNCTION(git_branch_upstream)
 PHP_FUNCTION(git_branch_upstream_name)
 {
 	php_git2_t *result = NULL;
-	char tracking_branch_name_out[512] = {0};
-	long buffer_size = 512;
+	char tracking_branch_name_out[GIT2_BUFFER_SIZE] = {0};
+	long buffer_size = GIT2_BUFFER_SIZE;
 	zval *repo = NULL;
 	php_git2_t *_repo = NULL;
 	char *canonical_branch_name = NULL;
@@ -289,8 +289,8 @@ PHP_FUNCTION(git_branch_is_head)
 PHP_FUNCTION(git_branch_remote_name)
 {
 	php_git2_t *result = NULL;
-	char remote_name_out[512] = {0};
-	long buffer_size = 512;
+	char remote_name_out[GIT2_BUFFER_SIZE] = {0};
+	long buffer_size = GIT2_BUFFER_SIZE;
 	zval *repo = NULL;
 	php_git2_t *_repo = NULL;
 	char *canonical_branch_name = NULL;

g_config.c

@@ -205,8 +205,8 @@ static void php_git2_config_entry_to_array(git_config_entry *entry, zval **resul
 */
 PHP_FUNCTION(git_config_find_global)
 {
-	char buffer[512];
-	size_t buffer_len = 512;
+	char buffer[GIT2_BUFFER_SIZE];
+	size_t buffer_len = GIT2_BUFFER_SIZE;
 	int error = 0;
 
 	error = git_config_find_global(buffer, buffer_len);
@@ -235,8 +235,8 @@ PHP_FUNCTION(git_config_find_xdg)
 */
 PHP_FUNCTION(git_config_find_system)
 {
-	char buffer[512];
-	size_t buffer_len = 512;
+	char buffer[GIT2_BUFFER_SIZE];
+	size_t buffer_len = GIT2_BUFFER_SIZE;
 	int error = 0;
 
 	error = git_config_find_system(buffer, buffer_len);

php_git2_priv.h

@@ -70,6 +70,8 @@ do {\
 } while (0);\
 
 #define GIT2_OID_HEXSIZE (GIT_OID_HEXSZ+1)
+#define GIT2_BUFFER_SIZE 512
+
 
 typedef struct php_git2_cb_t {
 	zval *payload;

reference.c

@@ -799,8 +799,8 @@ PHP_FUNCTION(git_reference_normalize_name)
 	char *name = {0};
 	int name_len;
 	long flags;
-	char buffer[512] = {0};
-	size_t buffer_sz = 512;
+	char buffer[GIT2_BUFFER_SIZE] = {0};
+	size_t buffer_sz = GIT2_BUFFER_SIZE;
 	int error = 0;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,

repository.c

@@ -244,8 +244,8 @@ PHP_FUNCTION(git_repository_discover)
 	char *ceiling_dirs = {0};
 	int ceiling_dirs_len;
 	int error = 0;
-	char buffer[512];
-	size_t buffer_len = 512;
+	char buffer[GIT2_BUFFER_SIZE];
+	size_t buffer_len = GIT2_BUFFER_SIZE;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,
 		"sls", &start_path, &start_path_len, &across_fs, &ceiling_dirs, &ceiling_dirs_len) == FAILURE) {
@@ -609,8 +609,8 @@ PHP_FUNCTION(git_repository_message)
 {
 	zval *repo;
 	php_git2_t *_repo;
-	char buffer[512];
-	size_t buffer_len = 512;
+	char buffer[GIT2_BUFFER_SIZE];
+	size_t buffer_len = GIT2_BUFFER_SIZE;
 	int error = 0;
 
 	if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC,