Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: RustPython/RustPython
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: echoappbr/RustPython
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Oct 3, 2024

  1. Make stdio a feature 

    When embedding RustPython into a graphical windows application (where
windows_subsystem = "windows"), it fails to create the RustPython VM.

This happens because the VM will try to open stdin/stdout/stderr when
initializing, but stdio isn't available for /SUBSYSTEM:WINDOWS apps.

This commit makes stdio a feature, so it can be disabled when needed.

https://doc.rust-lang.org/reference/runtime.html#the-windows_subsystem-attribute
https://learn.microsoft.com/en-us/cpp/build/reference/subsystem-specify-subsystem?view=msvc-170
https://asawicki.info/news_1768_ways_to_print_and_capture_text_output_of_a_process
    @danielstuart14
    danielstuart14 committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    84bdd8d View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Set stdio to None if feature is disabled 

    More in line with what CPython does
    @danielstuart14
    danielstuart14 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d4da84c View commit details
    Browse the repository at this point in the history
Loading