maint: remove monkey_patch functions.

* lib/std/init.lua (barrel, monkey_patch): Remove.
* lib/std/io.lua, lib/std/math.lua, lib/std/string.lua,
lib/std/table.lua (monkey_patch): Remove.
* specs/io_spec.yaml, specs/math_spec.yaml, specs/std_spec.yaml,
specs/string_spec.yaml, specs/table_spec.yaml: Remove examples
accordingly.
* NEWS.md: Update.

Signed-off-by: Gary V. Vaughan <gary@gnu.org>

Author: gvvaughan

NEWS.md

@@ -121,6 +121,11 @@
     `std.strict` and `std.tuple` have been moved to their own packages,
     and are no longer shipped as part of stdlib.
 
+  - Monkey patching calls `std.barrel`, `std.monkey_patch`,
+    `std.io.monkey_patch`, `std.math.monkey_patch`,
+    `std.string.monkey_patch` and `std.table.monkey_patch` have all
+    been removed.
+
   - `std.debug.argerror`, `std.debug.argcheck`, `std.debug.argscheck`,
     `std.debug.extramsg_mismatch`, `std.debug.extramsg_toomany`,
     `std.debug.parsetypes`, `std.debug.resulterror` and `std.debug.typesplit`
@@ -131,19 +136,13 @@
     removed.  At some point these will resurface in a new standalone
     package.
 
-  - Deprecated multi-argument `functional.bind` has been removed.
-
   - Deprecated methods `list:depair`, `list:elems`, `list:enpair`,
     `list:filter`, `list:flatten`, `list:foldl`, `list:foldr`,
     `list:index_key`, `list:index_value`, `list:map`, `list:map_with`,
     `list:project`, `list:relems`, `list:reverse`, `list:shape`,
     `list:transpose` and `list:zip_with` have been removed.
 
-  - Deprecated functions `functional.eval`, `functional.fold`,
-    `functional.op["[]"]`, `functional.op["+"]`, `functional.op["-"]`,
-    `functional.op["*"]`, `functional.op["/"], `functional.op["and"]',
-    `functional.op["or"]`, `functional.op["not"]`, `functional.op["=="]`,
-    `functional.op["~="]`, `list.depair`, `list.elems`, `list.enpair`,
+  - Deprecated functions `list.depair`, `list.elems`, `list.enpair`,
     `list.filter`, `list.flatten`, `list.foldl`, `list.foldr`,
     `list.index_key`, `list.index_value`, `list.map`, `list.map_with`,
     `list.project`, `list.relems`, `list.reverse`, `list.shape`,

lib/std/init.lua

@@ -1,16 +1,10 @@
 --[[--
  Enhanced Lua core functions, and others.
 
- After requiring this module, simply referencing symbols in the
- submodule hierarchy will load the necessary modules on demand.
-
- By default there are no changes to any global symbols, or monkey
- patching of core module tables and metatables.  However, sometimes it's
- still convenient to do that: For example, when using stdlib from the
- REPL, or in a prototype where you want to throw caution to the wind and
- compatibility with other modules be damned. In that case, you can give
- stdlib permission to scribble all over your namespaces by using the
- various `monkey_patch` calls in the library.
+ After requiring this module, simply referencing symbols in the submodule
+ hierarchy will load the necessary modules on demand. There are no
+ changes to any global symbols, or monkey patching of core module tables
+ and metatables.
 
  @todo Write a style guide (indenting/wrapping, capitalisation,
    function and variable names); library functions should call
@@ -21,7 +15,6 @@
 
 
 local _ENV		= _ENV
-local _G		= _G
 local error		= error
 local ipairs		= ipairs
 local pairs		= pairs
@@ -87,13 +80,7 @@ _ = nil
 --[[ =============== ]]--
 
 
-local M, monkeys
-
-
-local function monkey_patch (namespace)
-  copy (namespace or _G, monkeys)
-  return M
-end
+local M
 
 
 local function _assert (expect, fmt, arg1, ...)
@@ -102,37 +89,6 @@ local function _assert (expect, fmt, arg1, ...)
 end
 
 
-local function barrel (namespace)
-  namespace = namespace or _G
-
-  -- Older releases installed the following into _G by default.
-  for _, name in pairs {
-    "io.die", "io.warn",
-
-    "string.pickle", "string.prettytostring", "string.render",
-
-    "table.pack",
-
-    "tree.ileaves", "tree.inodes", "tree.leaves", "tree.nodes",
-  } do
-    local module, method = name:match "^(.*)%.(.-)$"
-    namespace[method] = M[module][method]
-  end
-
-  -- Support old api names, for backwards compatibility.
-  namespace.metamethod = M.getmetamethod
-  namespace.op = M.operator
-  namespace.require_version = M.require
-
-  require "std.io".monkey_patch (namespace)
-  require "std.math".monkey_patch (namespace)
-  require "std.string".monkey_patch (namespace)
-  require "std.table".monkey_patch (namespace)
-
-  return monkey_patch (namespace)
-end
-
-
 local function elems (t)
   -- capture _pairs iterator initial state
   local fn, istate, ctrl = _pairs (t)
@@ -255,29 +211,6 @@ M = {
   --- Module Functions
   -- @section modulefuncs
 
-  --- A [barrel of monkey_patches](http://dictionary.reference.com/browse/barrel+of+monkeys).
-  --
-  -- Apply **all** of stdlib's `monkey_patch` functions to *namespace*.
-  --
-  -- Additionally, for backwards compatibility only, write an historical
-  -- selection of stdlib submodule functions into the given namespace too
-  -- (at least until the next major release).
-  -- @function barrel
-  -- @tparam[opt=_G] table namespace where to install global functions
-  -- @treturn table module table
-  -- @usage local std = require "std".barrel ()
-  barrel = X ("barrel (?table)", barrel),
-
-  --- Overwrite core methods and metamethods with `std` enhanced versions.
-  --
-  -- Write all functions from this module, except `std.barrel` and
-  -- `std.monkey_patch`, into *namespace*.
-  -- @function monkey_patch
-  -- @tparam[opt=_G] table namespace where to install global functions
-  -- @treturn table the module table
-  -- @usage local std = require "std".monkey_patch ()
-  monkey_patch = X ("monkey_patch (?table)", monkey_patch),
-
   --- Enhance core `require` to assert version number compatibility.
   -- By default match against the last substring of (dot-delimited)
   -- digits in the module version string.
@@ -422,14 +355,6 @@ M = {
 }
 
 
-monkeys = copy ({}, M)
-
--- Don't monkey_patch these apis into _G!
-for _, api in ipairs {"barrel", "monkey_patch", "version"} do
-  monkeys[api] = nil
-end
-
-
 --- Metamethods
 -- @section Metamethods
 

lib/std/io.lua

@@ -43,7 +43,6 @@ local _DEBUG		= _.debug_init._DEBUG
 local _ipairs		= _.std.ipairs
 local _tostring		= _.std.tostring
 local catfile		= _.std.io.catfile
-local copy		= _.std.base.copy
 local dirsep		= _.std.package.dirsep
 local leaves		= _.std.tree.leaves
 local len		= _.std.operator.len
@@ -85,7 +84,7 @@ _ = nil
 --[[ =============== ]]--
 
 
-local M, monkeys
+local M
 
 
 local function input_handle (h)
@@ -134,21 +133,6 @@ local function writelines (h, ...)
 end
 
 
-local function monkey_patch (namespace)
-  namespace = namespace or _G
-  namespace.io = copy (namespace.io or {}, monkeys)
-
-  if namespace.io.stdin then
-    local mt = getmetatable (namespace.io.stdin) or {}
-    mt.readlines  = M.readlines
-    mt.writelines = M.writelines
-    setmetatable (namespace.io.stdin, mt)
-  end
-
-  return M
-end
-
-
 local function process_files (fn)
   -- N.B. "arg" below refers to the global array of command-line args
   if len (arg) == 0 then
@@ -284,19 +268,6 @@ M = {
                 function (path) return split (path, dirsep) end),
 
 
-  --- Module Functions
-  -- @section modulefuncs
-
-  --- Overwrite core `io` methods with `std` enhanced versions.
-  --
-  -- Also adds @{readlines} and @{writelines} metamethods to core file objects.
-  -- @function monkey_patch
-  -- @tparam[opt=_G] table namespace where to install global functions
-  -- @treturn table the `std.io` module table
-  -- @usage local io = require "std.io".monkey_patch ()
-  monkey_patch = X ("monkey_patch (?table)", monkey_patch),
-
-
   --- IO Functions
   -- @section iofuncs
 
@@ -351,9 +322,6 @@ M = {
 }
 
 
-monkeys = copy ({}, M)  -- before deprecations and core merge
-
-
 return merge (M, io)
 
 

lib/std/math.lua

@@ -22,7 +22,6 @@ local _ = {
 }
 
 local _DEBUG		= _.debug_init._DEBUG
-local copy		= _.std.base.copy
 local merge		= _.std.base.merge
 
 
@@ -69,13 +68,6 @@ local function floor (n, p)
 end
 
 
-local function monkey_patch (namespace)
-  namespace = namespace or _G
-  namespace.math = copy (namespace.math or {}, M)
-  return M
-end
-
-
 local function round (n, p)
   local e = 10 ^ (p or 0)
   return math_floor (n * e + 0.5) / e
@@ -112,17 +104,6 @@ M = {
   -- @treturn number `n` rounded to `p` decimal places
   -- @usage roughly = round (exactly, 2)
   round = X ("round (number, ?int)", round),
-
-
-  --- Module Functions
-  -- @section modulefuncs
-
-  --- Overwrite core `math` methods with `std` enhanced versions.
-  -- @function monkey_patch
-  -- @tparam[opt=_G] table namespace where to install global functions
-  -- @treturn table the module table
-  -- @usage require "std.math".monkey_patch ()
-  monkey_patch = X ("monkey_patch (?table)", monkey_patch),
 }
 
 

lib/std/string.lua

@@ -124,18 +124,6 @@ local function finds (s, p, i, ...)
 end
 
 
-local function monkey_patch (namespace)
-  namespace = namespace or _G
-  namespace.string = copy (namespace.string or {}, M)
-
-  local string_metatable = getmetatable ""
-  string_metatable.__concat = M.__concat
-  string_metatable.__index = M.__index
-
-  return M
-end
-
-
 local function caps (s)
   return (s:gsub ("(%w)([%w]*)", function (l, ls) return l:upper () .. ls end))
 end
@@ -302,7 +290,7 @@ M = {
   -- @param o object to stringify and concatenate
   -- @return s .. tostring (o)
   -- @usage
-  -- local string = require "std.string".monkey_patch ()
+  -- local string = setmetatable ("", require "std.string")
   -- concatenated = "foo" .. {"bar"}
   __concat = __concat,
 
@@ -492,20 +480,6 @@ M = {
   -- @usage
   -- print (wrap (copyright, 72, 4))
   wrap = X ("wrap (string, ?int, ?int, ?int)", wrap),
-
-
-  --- Module Functions
-  -- @section modulefuncs
-
-  --- Overwrite core `string` methods with `std` enhanced versions.
-  --
-  -- Also adds auto-stringification to `..` operator on core strings, and
-  -- integer indexing of strings with `[]` dereferencing.
-  -- @function monkey_patch
-  -- @tparam[opt=_G] table namespace where to install global functions
-  -- @treturn table the module table
-  -- @usage local string = require "std.string".monkey_patch ()
-  monkey_patch = X ("monkey_patch (?table)", monkey_patch),
 }
 
 

lib/std/table.lua

@@ -75,7 +75,7 @@ _ = nil
 --[[ =============== ]]--
 
 
-local M, monkeys
+local M
 
 
 local function merge_allfields (t, u, map, nometa)
@@ -180,13 +180,6 @@ local function sort (t, c)
 end
 
 
-local function monkey_patch (namespace)
-  namespace = namespace or _G
-  namespace.table = copy (namespace.table or {}, monkeys)
-  return M
-end
-
-
 local _remove = table.remove
 
 local function remove (t, pos)
@@ -444,23 +437,9 @@ M = {
   -- @usage merge_select (_G, require "std.debug", {"say"}, false)
   merge_select = X ("merge_select (table, table, [table], ?boolean|:nometa)",
                     merge_namedfields),
-
-
-  --- Module Functions
-  -- @section modulefuncs
-
-  --- Overwrite core `table` methods with `std` enhanced versions.
-  -- @function monkey_patch
-  -- @tparam[opt=_G] table namespace where to install global functions
-  -- @treturn table the module table
-  -- @usage local table = require "std.table".monkey_patch ()
-  monkey_patch = X ("monkey_patch (?table)", monkey_patch),
 }
 
 
-monkeys = copy ({}, M)  -- before deprecations and core merge
-
-
 return merge (M, table)