From 9a5bef3d78fd63ba6b5624745471684410ea0e03 Mon Sep 17 00:00:00 2001 From: Samuel Bellomo Date: Sun, 27 Jun 2021 18:18:35 -0400 Subject: [PATCH] putting log level for delta warning to developer. This was generating a lot of useless noise during perf tests and creating a lot of GC alloc when spawning multiple network objects. There's also another error log when the message is actually dropped. Adding more details when receiving data, better message log --- com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs | 2 +- .../Runtime/Messaging/InternalMessageHandler.cs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs b/com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs index 207ba51fb0..87741924a9 100644 --- a/com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs +++ b/com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs @@ -1173,7 +1173,7 @@ internal void HandleIncomingData(ulong clientId, NetworkChannel networkChannel, if (NetworkLog.CurrentLogLevel <= LogLevel.Developer) { - NetworkLog.LogInfo($"Data Header: {nameof(messageType)}={messageType}"); + NetworkLog.LogInfo($"Handling incoming Data Header: {nameof(messageType)}={NetworkConstants.MESSAGE_NAMES[messageType]}(int={messageType})"); } // Client tried to send a network message that was not the connection request before he was accepted. diff --git a/com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs b/com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs index 82a8be7f1e..c9a27ebf91 100644 --- a/com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs +++ b/com.unity.multiplayer.mlapi/Runtime/Messaging/InternalMessageHandler.cs @@ -317,7 +317,7 @@ public void HandleNetworkVariableDelta(ulong clientId, Stream stream, Action