From 3abace7da760ec0b2dc9534fdd09630309f4875d Mon Sep 17 00:00:00 2001 From: kvassall-unity Date: Thu, 9 Sep 2021 14:12:34 -0500 Subject: [PATCH 1/2] chore: Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. --- .../Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs b/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs index 9aeaee346b..c4fbb22642 100644 --- a/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs +++ b/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs @@ -15,7 +15,8 @@ public class NetworkMetricsRegistrationTests .Where(x => x.GetInterfaces().Contains(typeof(INetworkMetricEvent))) .ToArray(); - [TestCaseSource(nameof(s_MetricTypes))] + // Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. + //[TestCaseSource(nameof(s_MetricTypes))] public void ValidateThatAllMetricTypesAreRegistered(Type metricType) { var dispatcher = new NetworkMetrics().Dispatcher as MetricDispatcher; From ad3619884532f002f390c8e5daed503f244400f3 Mon Sep 17 00:00:00 2001 From: kvassall-unity Date: Thu, 9 Sep 2021 15:47:00 -0500 Subject: [PATCH 2/2] Use ignore attribute --- .../Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs b/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs index c4fbb22642..56fb1321ee 100644 --- a/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs +++ b/com.unity.netcode.gameobjects/Tests/Editor/Metrics/NetworkMetricsRegistrationTests.cs @@ -15,8 +15,7 @@ public class NetworkMetricsRegistrationTests .Where(x => x.GetInterfaces().Contains(typeof(INetworkMetricEvent))) .ToArray(); - // Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI. - //[TestCaseSource(nameof(s_MetricTypes))] + [TestCaseSource(nameof(s_MetricTypes))][Ignore("Disable test while we reevaluate the assumption that INetworkMetricEvent interfaces must be reported from MLAPI.")] public void ValidateThatAllMetricTypesAreRegistered(Type metricType) { var dispatcher = new NetworkMetrics().Dispatcher as MetricDispatcher;