Implement array getitem by slice

Author: qingshi163

Lib/test/test_array.py

@@ -739,8 +739,6 @@ def test_delitem(self):
         self.assertRaises(IndexError, a.__delitem__, len(self.example))
         self.assertRaises(IndexError, a.__delitem__, -len(self.example)-1)
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_getslice(self):
         a = array.array(self.typecode, self.example)
         self.assertEqual(a[:], a)
@@ -791,8 +789,6 @@ def test_getslice(self):
             array.array(self.typecode)
         )
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_extended_getslice(self):
         # Test extended slicing by comparing with list slicing
         # (Assumes list conversion works correctly, too)
@@ -1206,8 +1202,6 @@ def test_issue17223(self):
 
 class NumberTest(BaseTest):
 
-    # TODO: RUSTPYTHON
-    @unittest.expectedFailure
     def test_extslice(self):
         a = array.array(self.typecode, range(5))
         self.assertEqual(a[::], a)

vm/src/stdlib/array.rs

@@ -4,13 +4,14 @@ use crate::common::cell::{
 };
 use crate::function::OptionalArg;
 use crate::obj::objbytes::PyBytesRef;
+use crate::obj::objsequence::PySliceableSequence;
 use crate::obj::objslice::PySliceRef;
 use crate::obj::objstr::PyStringRef;
 use crate::obj::objtype::PyClassRef;
 use crate::obj::{objbool, objiter};
 use crate::pyobject::{
     BorrowValue, Either, IntoPyObject, PyArithmaticValue, PyClassImpl, PyComparisonValue,
-    PyIterable, PyObjectRef, PyRef, PyResult, PyValue, TryFromObject,
+    PyIterable, PyObject, PyObjectRef, PyRef, PyResult, PyValue, TryFromObject,
 };
 use crate::VirtualMachine;
 use crossbeam_utils::atomic::AtomicCell;
@@ -194,14 +195,31 @@ macro_rules! def_array_enum {
                 }
             }
 
+            fn getitem_by_slice(&self, slice: PySliceRef, vm: &VirtualMachine) -> PyResult<PyObjectRef> {
+                match self {
+                    $(ArrayContentType::$n(v) => {
+                        let elements = v.get_slice_items(vm, &slice)?;
+                        let sliced = ArrayContentType::$n(elements);
+                        let obj = PyObject::new(
+                            PyArray {
+                                array: PyRwLock::new(sliced)
+                            },
+                            PyArray::class(vm),
+                            None
+                        );
+                        Ok(obj)
+                    })*
+                }
+            }
+
             fn getitem(&self, needle: Either<isize, PySliceRef>, vm: &VirtualMachine) -> PyResult {
                 match needle {
                     Either::A(i) => {
                         self.idx(i, "array", vm).map(|i| {
                             self.getitem_by_idx(i, vm).unwrap()
                         })
                     }
-                    Either::B(_slice) => Err(vm.new_not_implemented_error("array slice is not implemented".to_owned())),
+                    Either::B(slice) => self.getitem_by_slice(slice, vm),
                 }
             }