Skip to content

Commit 4d48f43

Browse files
pyTypeFactory return type leak fixed
1 parent 26203ac commit 4d48f43

7 files changed

Lines changed: 7 additions & 7 deletions

File tree

include/BufferType.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ public:
2323
*
2424
* @param cx - javascript context pointer
2525
* @param bufObj - JS object to be coerced
26-
*
26+
*
2727
* @returns PyObject* pointer to the resulting PyObject
2828
*/
2929
static PyObject *getPyObject(JSContext *cx, JS::HandleObject bufObj);

include/DictType.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ public:
2727
*
2828
* @param cx - pointer to the JSContext
2929
* @param jsObject - pointer to the JSObject to be coerced
30-
*
30+
*
3131
* @returns PyObject* pointer to the resulting PyObject
3232
*/
3333
static PyObject *getPyObject(JSContext *cx, JS::Handle<JS::Value> jsObject);

include/ExceptionType.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public:
2525
*
2626
* @param cx - javascript context pointer
2727
* @param error - JS Error object to be converted
28-
*
28+
*
2929
* @returns PyObject* pointer to the resulting PyObject
3030
*/
3131
static PyObject *getPyObject(JSContext *cx, JS::HandleObject error);

include/IntType.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public:
2525
*
2626
* @param cx - javascript context pointer
2727
* @param bigint - JS::BigInt pointer
28-
*
28+
*
2929
* @returns PyObject* pointer to the resulting PyObject
3030
*/
3131
static PyObject *getPyObject(JSContext *cx, JS::BigInt *bigint);

include/PromiseType.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ public:
2626
*
2727
* @param cx - javascript context pointer
2828
* @param promise - JS::PromiseObject to be coerced
29-
*
29+
*
3030
* @returns PyObject* pointer to the resulting PyObject
3131
*/
3232
static PyObject *getPyObject(JSContext *cx, JS::HandleObject promise);

include/StrType.hh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ public:
3131
*
3232
* @param cx - javascript context pointer
3333
* @param str - JSString pointer
34-
*
34+
*
3535
* @returns PyObject* pointer to the resulting PyObject
3636
*/
3737
static PyObject *getPyObject(JSContext *cx, JSString *str);

src/internalBinding/timers.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ static bool enqueueWithDelay(JSContext *cx, unsigned argc, JS::Value *vp) {
2727

2828
// Convert to a Python function
2929
JS::RootedValue jobArg(cx, jobArgVal);
30-
PyObject *job = pyTypeFactory(cx, jobArg)->getPyObject();
30+
PyObject *job = pyTypeFactory(cx, jobArg);
3131
// Schedule job to the running Python event-loop
3232
PyEventLoop loop = PyEventLoop::getRunningLoop();
3333
if (!loop.initialized()) return false;

0 commit comments

Comments
 (0)