From f8ff15a79c060c31647ae965c3cebec2d7c249fb Mon Sep 17 00:00:00 2001 From: Dave Abrahams Date: Thu, 9 Nov 2023 11:31:51 -0800 Subject: [PATCH 1/2] Make sure failures in multiline CI steps are not swallowed. Without this change, it is possible to have a passing CI job even though the build failed, e.g. https://github.com/dabrahams/CBORCoding/actions/runs/6806944368/job/18509010389#step:4:99 --- .github/workflows/carthage.yml | 3 +++ .github/workflows/cocoapods.yml | 3 +++ .github/workflows/documentation.yml | 3 +++ .github/workflows/publish-cocoapods.yml | 3 +++ .github/workflows/swift-package.yml | 3 +++ .github/workflows/swiftlint.yml | 3 +++ .github/workflows/upload-assets.yml | 3 +++ .github/workflows/xcframework.yml | 3 +++ .github/workflows/xcodebuild.yml | 3 +++ 9 files changed, 27 insertions(+) diff --git a/.github/workflows/carthage.yml b/.github/workflows/carthage.yml index e32a033..b50473b 100644 --- a/.github/workflows/carthage.yml +++ b/.github/workflows/carthage.yml @@ -1,4 +1,7 @@ name: Carthage +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: diff --git a/.github/workflows/cocoapods.yml b/.github/workflows/cocoapods.yml index 63d3eaf..3fcbac0 100644 --- a/.github/workflows/cocoapods.yml +++ b/.github/workflows/cocoapods.yml @@ -1,4 +1,7 @@ name: Cocoapods +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml index ade539a..f51bac2 100644 --- a/.github/workflows/documentation.yml +++ b/.github/workflows/documentation.yml @@ -1,4 +1,7 @@ name: Documentation +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: diff --git a/.github/workflows/publish-cocoapods.yml b/.github/workflows/publish-cocoapods.yml index e97f57f..0014b0a 100644 --- a/.github/workflows/publish-cocoapods.yml +++ b/.github/workflows/publish-cocoapods.yml @@ -1,4 +1,7 @@ name: Publish CocoaPods +defaults: + run: + shell: bash -eo pipefail {0} on: release: types: [published] diff --git a/.github/workflows/swift-package.yml b/.github/workflows/swift-package.yml index 0ade64f..8af012d 100644 --- a/.github/workflows/swift-package.yml +++ b/.github/workflows/swift-package.yml @@ -1,4 +1,7 @@ name: Swift Package +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: diff --git a/.github/workflows/swiftlint.yml b/.github/workflows/swiftlint.yml index 8ff1afe..48950d6 100644 --- a/.github/workflows/swiftlint.yml +++ b/.github/workflows/swiftlint.yml @@ -1,4 +1,7 @@ name: SwiftLint +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: diff --git a/.github/workflows/upload-assets.yml b/.github/workflows/upload-assets.yml index a9c7d36..8338df3 100644 --- a/.github/workflows/upload-assets.yml +++ b/.github/workflows/upload-assets.yml @@ -1,4 +1,7 @@ name: Upload Assets +defaults: + run: + shell: bash -eo pipefail {0} on: release: types: [published] diff --git a/.github/workflows/xcframework.yml b/.github/workflows/xcframework.yml index 496ea0b..89789d9 100644 --- a/.github/workflows/xcframework.yml +++ b/.github/workflows/xcframework.yml @@ -1,4 +1,7 @@ name: XCFramework +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: diff --git a/.github/workflows/xcodebuild.yml b/.github/workflows/xcodebuild.yml index 6121faf..81b8e77 100644 --- a/.github/workflows/xcodebuild.yml +++ b/.github/workflows/xcodebuild.yml @@ -1,4 +1,7 @@ name: Xcode Project +defaults: + run: + shell: bash -eo pipefail {0} on: workflow_dispatch: push: From 4cdf8fc037eefa187876b753df7422310a7308d9 Mon Sep 17 00:00:00 2001 From: Dave Abrahams Date: Thu, 9 Nov 2023 11:39:06 -0800 Subject: [PATCH 2/2] Add self to CONTRIBUTORS --- .github/CONTRIBUTORS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CONTRIBUTORS.md b/.github/CONTRIBUTORS.md index 5a3eeb2..40111ad 100644 --- a/.github/CONTRIBUTORS.md +++ b/.github/CONTRIBUTORS.md @@ -5,6 +5,7 @@ I would like to give a special thanks to all of the people below who have contributed to this project and to all of those who will contribute to it moving forward. - [Jos Kuijpers](https://github.com/joskuijpers) +- [Dave Abrahams](https://github.com/dabrahams) ## I would like to join this list! How can I help the project?