Skip to content

Commit 012cdf5

Browse files
committed
Merge remote-tracking branch 'origin/develop' into develop
2 parents ac42fbb + 1ff6d48 commit 012cdf5

File tree

5 files changed

+20
-7
lines changed

5 files changed

+20
-7
lines changed

docs/translating.md

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,11 @@
66
- Be able to understand English
77
- Be able to understand the language you want to translate riot-web into
88

9+
## Step 0: Join #riotweb-translations:matrix.org
10+
11+
1. Come and join https://riot.im/develop/#/room/#riotweb-translations:matrix.org
12+
2. Read scrollback and/or ask if anyone else is working on your language, and co-ordinate if needed. In general little-or-no coordination is needed though :)
13+
914
## Step 1: Preparing your Weblate Profile
1015

1116
1. Head to https://translate.nordgedanken.de and register either via Github or email
@@ -45,12 +50,15 @@ The yellow button has to be used if you are unsure about the translation but you
4550

4651
### What are "%(something)s"?
4752

48-
These things are variables that are filled inside the code. They can be room names, usernames or similiar. If you find one use it for changing the word order but do not delete it as thing are missing if you do so.
53+
These things are variables that are expanded when displayed by Riot. They can be room names, usernames or similar. If you find one, you can move to the right place for your language, but not delete it as the variable will be missing if you do.
54+
55+
A special case is `%(urlStart)s` and `%(urlEnd)s` which are used to mark the beginning of a hyperlink (i.e. `<a href="/somewhere">` and `</a>`. You must keep these markers surrounding the equivalent string in your language that needs to be hyperlinked.
4956

5057
### "I want to come back to this string. How?"
5158

5259
You can use inside the translation field "Review needed" checkbox. It will be shown as Strings that need to be reviewed.
5360

61+
5462
### Further reading
5563

56-
The official Doc provides some more in-deepth explanation on how to do translations and talks about do and don't's. You can find it at: https://docs.weblate.org/en/latest/user/translating.html
64+
The official Weblate doc provides some more in-deepth explanation on how to do translations and talks about do and don'ts. You can find it at: https://docs.weblate.org/en/latest/user/translating.html

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@
104104
"emojione": "^2.2.7",
105105
"eslint": "^3.14.0",
106106
"eslint-config-google": "^0.7.1",
107+
"eslint-plugin-babel": "^4.1.1",
107108
"eslint-plugin-flowtype": "^2.30.0",
108109
"eslint-plugin-react": "^6.9.0",
109110
"expect": "^1.16.0",

scripts/fetch-develop.deps.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,13 @@ dodep matrix-org matrix-react-sdk
4040
mkdir -p node_modules
4141
cd node_modules
4242

43+
rm -r matrix-js-sdk 2> /dev/null
4344
ln -s ../matrix-js-sdk ./
4445
pushd matrix-js-sdk
4546
npm install
4647
popd
4748

49+
rm -r matrix-react-sdk 2> /dev/null
4850
ln -s ../matrix-react-sdk ./
4951
pushd matrix-react-sdk
5052
mkdir -p node_modules

scripts/jenkins.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,9 @@ npm run lintall -- -f checkstyle -o eslint.xml || true
3434

3535
rm dist/riot-*.tar.gz || true # rm previous artifacts without failing if it doesn't exist
3636

37-
# node_modules deps from 'npm install' don't have a .git dir so can't
38-
# rev-parse; but they do set the commit in package.json under 'gitHead' which
39-
# we're grabbing here.
40-
REACT_SHA=$(grep 'gitHead' node_modules/matrix-react-sdk/package.json | cut -d \" -f 4 | head -c 12)
41-
JSSDK_SHA=$(grep 'gitHead' node_modules/matrix-js-sdk/package.json | cut -d \" -f 4 | head -c 12)
37+
# Since the deps are fetched from git, we can rev-parse
38+
REACT_SHA=$(cd node_modules/matrix-react-sdk; git rev-parse --short=12 HEAD)
39+
JSSDK_SHA=$(cd node_modules/matrix-js-sdk; git rev-parse --short=12 HEAD)
4240

4341
VECTOR_SHA=$(git rev-parse --short=12 HEAD) # use the ACTUAL SHA rather than assume develop
4442

src/skins/vector/css/matrix-react-sdk/views/rooms/_EventTile.scss

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -183,6 +183,10 @@ limitations under the License.
183183
visibility: visible;
184184
}
185185

186+
.mx_MessagePanel_alwaysShowTimestamps .mx_MessageTimestamp {
187+
visibility: visible;
188+
}
189+
186190
.mx_EventTile_selected .mx_MessageTimestamp {
187191
left: 3px;
188192
}

0 commit comments

Comments
 (0)