clean up imports and useless allow attributes

Author: youknowone

benches/execution.rs

@@ -4,8 +4,7 @@ use criterion::{
 };
 use rustpython_compiler::Mode;
 use rustpython_parser::parser::parse_program;
-use rustpython_vm::Interpreter;
-use rustpython_vm::PyResult;
+use rustpython_vm::{Interpreter, PyResult};
 use std::collections::HashMap;
 use std::path::Path;
 

benches/microbenchmarks.rs

@@ -1,13 +1,15 @@
-use criterion::measurement::WallTime;
 use criterion::{
-    criterion_group, criterion_main, BatchSize, BenchmarkGroup, BenchmarkId, Criterion, Throughput,
+    criterion_group, criterion_main, measurement::WallTime, BatchSize, BenchmarkGroup, BenchmarkId,
+    Criterion, Throughput,
 };
 use rustpython_compiler::Mode;
 use rustpython_vm::{
     common::ascii, InitParameter, Interpreter, PyObjectWrap, PyResult, PySettings,
 };
-use std::path::{Path, PathBuf};
-use std::{ffi, fs, io};
+use std::{
+    ffi, fs, io,
+    path::{Path, PathBuf},
+};
 
 pub struct MicroBenchmark {
     name: String,

bytecode/src/lib.rs

@@ -10,8 +10,7 @@ use itertools::Itertools;
 use num_bigint::BigInt;
 use num_complex::Complex64;
 use serde::{Deserialize, Serialize};
-use std::collections::BTreeSet;
-use std::{fmt, hash};
+use std::{collections::BTreeSet, fmt, hash};
 
 /// Sourcecode location.
 #[derive(Clone, Copy, Debug, Default, PartialEq, Serialize, Deserialize)]

common/src/boxvec.rs

@@ -1,9 +1,13 @@
 //! An unresizable vector backed by a `Box<[T]>`
 
-use std::borrow::{Borrow, BorrowMut};
-use std::mem::{self, MaybeUninit};
-use std::ops::{Bound, Deref, DerefMut, RangeBounds};
-use std::{alloc, cmp, fmt, ptr, slice};
+use std::{
+    alloc,
+    borrow::{Borrow, BorrowMut},
+    cmp, fmt,
+    mem::{self, MaybeUninit},
+    ops::{Bound, Deref, DerefMut, RangeBounds},
+    ptr, slice,
+};
 
 pub struct BoxVec<T> {
     xs: Box<[MaybeUninit<T>]>,
@@ -501,9 +505,7 @@ impl<T> Drop for Drain<'_, T> {
     fn drop(&mut self) {
         // len is currently 0 so panicking while dropping will not cause a double drop.
 
-        // exhaust self first, clippy warning here is seemingly a fluke.
-        #[allow(clippy::while_let_on_iterator)]
-        while let Some(_) = self.next() {}
+        for _ in self.by_ref() {}
 
         if self.tail_len > 0 {
             unsafe {

common/src/hash.rs

@@ -2,8 +2,10 @@ use num_bigint::BigInt;
 use num_complex::Complex64;
 use num_traits::ToPrimitive;
 use siphasher::sip::SipHasher24;
-use std::hash::{BuildHasher, Hash, Hasher};
-use std::num::Wrapping;
+use std::{
+    hash::{BuildHasher, Hash, Hasher},
+    num::Wrapping,
+};
 
 pub type PyHash = i64;
 pub type PyUHash = u64;

common/src/lock/cell_lock.rs

@@ -2,8 +2,7 @@ use lock_api::{
     GetThreadId, RawMutex, RawRwLock, RawRwLockDowngrade, RawRwLockRecursive, RawRwLockUpgrade,
     RawRwLockUpgradeDowngrade,
 };
-use std::cell::Cell;
-use std::num::NonZeroUsize;
+use std::{cell::Cell, num::NonZeroUsize};
 
 pub struct RawCellMutex {
     locked: Cell<bool>,

common/src/lock/immutable_mutex.rs

@@ -1,8 +1,5 @@
-use std::fmt;
-use std::marker::PhantomData;
-use std::ops::Deref;
-
 use lock_api::{MutexGuard, RawMutex};
+use std::{fmt, marker::PhantomData, ops::Deref};
 
 /// A mutex guard that has an exclusive lock, but only an immutable reference; useful if you
 /// need to map a mutex guard with a function that returns an `&T`. Construct using the

common/src/lock/thread_mutex.rs

@@ -1,11 +1,12 @@
-use std::cell::UnsafeCell;
-use std::fmt;
-use std::marker::PhantomData;
-use std::ops::{Deref, DerefMut};
-use std::ptr::NonNull;
-use std::sync::atomic::{AtomicUsize, Ordering};
-
 use lock_api::{GetThreadId, GuardNoSend, RawMutex};
+use std::{
+    cell::UnsafeCell,
+    fmt,
+    marker::PhantomData,
+    ops::{Deref, DerefMut},
+    ptr::NonNull,
+    sync::atomic::{AtomicUsize, Ordering},
+};
 
 // based off ReentrantMutex from lock_api
 

common/src/str.rs

@@ -1,7 +1,9 @@
 use ascii::AsciiString;
 use once_cell::unsync::OnceCell;
-use std::fmt;
-use std::ops::{Bound, RangeBounds};
+use std::{
+    fmt,
+    ops::{Bound, RangeBounds},
+};
 
 #[cfg(not(target_arch = "wasm32"))]
 #[allow(non_camel_case_types)]
@@ -99,8 +101,7 @@ pub const fn bytes_is_ascii(x: &str) -> bool {
 }
 
 pub mod levenshtein {
-    use std::cell::RefCell;
-    use std::thread_local;
+    use std::{cell::RefCell, thread_local};
 
     pub const MOVE_COST: usize = 2;
     const CASE_COST: usize = 1;

compiler/src/compile.rs

@@ -88,7 +88,6 @@ struct CompileContext {
 }
 
 #[derive(Debug, Clone, Copy, PartialEq)]
-#[allow(clippy::enum_variant_names)]
 enum FunctionContext {
     NoFunction,
     Function,