forked from github/codeql
-
Notifications
You must be signed in to change notification settings - Fork 0
Expand file tree
/
Copy pathUselessConditional.js
More file actions
192 lines (166 loc) · 3.17 KB
/
UselessConditional.js
File metadata and controls
192 lines (166 loc) · 3.17 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
function getLastLine(input) {
var lines = [], nextLine;
while ((nextLine = readNextLine(input)))
lines.push(nextLine);
if (!lines)
throw new Error("No lines!");
return lines[lines.length-1];
}
function lookup(cache, k) {
var v;
return k in cache ? cache[k] : (v = new Entry(recompute())) && (cache[k] = v);
}
function test(a, b) {
if (!a && !b) {
if (a);
if (b);
}
if (!(a || b)) {
if (a);
if (b);
}
var x = new X();
if(x){}
if (new X()){}
if((x)){}
if(((x))){}
if ((new X())){}
x = 0n;
if (x) // NOT OK
;
}
async function awaitFlow(){
var v;
if (y)
v = await f()
if (v) { // OK
}
}
(function(){
function knownF() {
return false;
}
var known = knownF();
if (known)
return;
if (known)
return;
var unknown = unknownF();
if (unknown)
return;
if (unknown) // NOT OK
return;
});
(function (...x) {
x || y // NOT OK
});
(function() {
function f1(x) {
x || y // NOT OK, but whitelisted
}
f1(true);
function f2(x) {
while (true)
x || y // NOT OK
}
f2(true);
function f3(x) {
(function(){
x || y // NOT OK, but whitelisted
});
}
f3(true);
});
(function() {
if ((x, true));
});
(function (x, y) {
if (!x) {
while (x) { // NOT OK
f();
}
while (true) { // OK
break;
}
if (true && true) {} // NOT OK
if (y && x) {} // NOT OK
if (y && (x)) {} // NOT OK
do { } while (x); // NOT OK
}
});
(function(x,y) {
let obj = (x && {}) || y; // OK
if ((x && {}) || y) {} // NOT OK
});
(function(){
function constantFalse1() {
return false;
}
if (constantFalse1()) // OK
return;
function constantFalse2() {
return false;
}
let constantFalse = unknown? constantFalse1 : constantFalse2;
if (constantFalse2()) // OK
return;
function constantUndefined() {
return undefined;
}
if (constantUndefined()) // NOT OK
return;
function constantFalseOrUndefined1() {
return unknown? false: undefined;
}
if (constantFalseOrUndefined1()) // NOT OK
return;
let constantFalseOrUndefined2 = unknown? constantFalse1 : constantUndefined;
if (constantFalseOrUndefined2()) // NOT OK
return;
});
(function () {
function p() {
return {};
}
if (p()) { // NOT OK
}
var v = p();
if (v) { // NOT OK
}
if (v) { // NOT OK, but not detected due to SSA limitations
}
});
(function() {
function findOrThrow() {
var e = find();
if (e) return e;
throw new Error();
}
if(findOrThrow()){ // NOT OK
}
var v = findOrThrow();
if (v) { // NOT OK
}
if (v) { // NOT OK, but not detected due to SSA limitations
}
});
(function () {
function f(){ return { v: unkown };}
f();
var { v } = f();
if (v) { // OK
}
});
(function() {
function outer(x) {
addEventListener("click", () => {
if (!x && something()) { // NOT OK, but whitelisted
something();
}
});
}
function inner() {
outer(); // Omit parameter
}
inner();
});