codeql/java/ql/test/query-tests/ContainerSizeCmpZero/Main.java at sauyon/java-spring-stringutils · ByteDecoder/codeql · GitHub

1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
import java.util.*;

public class Main {

    public static void arrays(String[] args) {

        // NOT OK: always true
        if (args.length >= 0) {
            System.out.println("At least zero arguments!!");
        }

        // NOT OK: always true
        if (0 <= args.length) {
            System.out.println("At least zero arguments!!");
        }

        // NOT OK: always false
        if (args.length < 0) {
            System.out.println("At least zero arguments!!");
        }

        // NOT OK: always false
        if (0 > args.length) {
            System.out.println("At least zero arguments!!");
        }

        // OK: sometimes could be false
        if (args.length > 0) {
            System.out.println("Greater than zero arguments!!");
        }

        // OK: sometimes could be false
        if (0 < args.length) {
            System.out.println("Greater than zero arguments!!");
        }

        // OK: sometimes could be true
        if (args.length <= 0) {
            System.out.println("Greater than zero arguments!!");
        }

        // OK: sometimes could be true
        if (0 >= args.length) {
            System.out.println("Greater than zero arguments!!");
        }

    }

    public static void containers(ArrayList<String> xs,
                                  Vector<String> ys) {
        Boolean b;

        // NOT OK
        b = xs.size() >= 0;
        b = 0 <= xs.size();
        b = 0 <= ys.size();

        b = xs.size() < 0;
        b = 0 > ys.size();

        // OK
        b = xs.size() >= -1;

        // OK
        b = 0 < xs.size();
    }

    // Slight obfuscations that the query doesn't match currently
    public static void missedCases(ArrayList<String> xs) {
        Boolean b;

        // OK: not currently matched
        b = xs.size() >= (short)0;
        b = xs.size() >= (byte)0;
        b = xs.size() >= 0 + 0;
        b = xs.size() >= 0 - 0;
    }

    public static void nestedContainers(Vector<ArrayList<String>> xs) {
        Boolean b;

        // NOT OK
        b = xs.size() >= 0;
        b = xs.size() < 0;

        // NOT OK
        b = xs.get(0).size() >= 0;

        // NOT OK
        b = xs.get(0).get(0).length() >= 0;
    }

    public static void mapTests(TreeMap<String, String> xs) {
        Boolean b;

        // NOT OK: Always true
        b = xs.size() >= 0;

        // NOT OK: Always true
        b = 0 <= xs.size();

        // OK: can be false
        b = xs.size() >= -1;

        // OK: can be false
        b = 0 < xs.size();
    }

    public static void rawTypes(Set s, ArrayList a, HashMap m) {
        Boolean b;

        // NOT OK
        b = s.size() >= 0;
        b = a.size() >= 0;
        b = 0 <= m.size();
    }

}