Skip to content

Commit b2c0283

Browse files
authored
Remove todos from vm
1 parent 5a743d5 commit b2c0283

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

bytecode/src/lib.rs

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ use std::collections::BTreeSet;
1414
use std::{fmt, hash};
1515

1616
/// Sourcecode location.
17-
/// TODO start, end, middle?
1817
#[derive(Clone, Copy, Debug, Default, PartialEq, Serialize, Deserialize)]
1918
pub struct Location {
2019
row: usize,
@@ -44,8 +43,6 @@ impl Location {
4443
}
4544
}
4645

47-
/// A Constant object is
48-
/// TODO unclear
4946
pub trait Constant: Sized {
5047
type Name: AsRef<str>;
5148

@@ -56,8 +53,6 @@ pub trait Constant: Sized {
5653
self.borrow_constant().into_data()
5754
}
5855
/// Map this Constant to a Bag's constant
59-
///
60-
/// TODO Unclear.
6156
fn map_constant<Bag: ConstantBag>(self, bag: &Bag) -> Bag::Constant {
6257
bag.make_constant(self.into_data())
6358
}
@@ -588,7 +583,6 @@ pub enum ComparisonOperator {
588583
Is,
589584
IsNot,
590585
/// two exceptions that match?
591-
/// TODO clarify
592586
ExceptionMatch,
593587
}
594588

@@ -635,7 +629,6 @@ pub enum BlockType {
635629
*/
636630

637631
/// Argument structure
638-
/// TODO is this for parameters or arguments?
639632
pub struct Arguments<'a, N: AsRef<str>> {
640633
pub posonlyargs: &'a [N],
641634
pub args: &'a [N],
@@ -664,10 +657,6 @@ impl<N: AsRef<str>> fmt::Debug for Arguments<'_, N> {
664657
impl<C: Constant> CodeObject<C> {
665658
/// Get all arguments of the code object
666659
/// like inspect.getargs
667-
/// # Examples
668-
///
669-
/// TODO I'm not sure what is the best way to construct a CodeObject
670-
///
671660
pub fn arg_names(&self) -> Arguments<C::Name> {
672661
let nargs = self.arg_count;
673662
let nkwargs = self.kwonlyarg_count;
@@ -753,7 +742,6 @@ impl<C: Constant> CodeObject<C> {
753742
}
754743

755744
/// Map this CodeObject to one that holds a Bag::Constant
756-
/// TODO add example
757745
pub fn map_bag<Bag: ConstantBag>(self, bag: &Bag) -> CodeObject<Bag::Constant> {
758746
let map_names = |names: Box<[C::Name]>| {
759747
names
@@ -789,7 +777,6 @@ impl<C: Constant> CodeObject<C> {
789777
}
790778

791779
/// Same as `map_bag` but clones `self`
792-
/// TODO add example
793780
pub fn map_clone_bag<Bag: ConstantBag>(&self, bag: &Bag) -> CodeObject<Bag::Constant> {
794781
let map_names = |names: &[C::Name]| {
795782
names
@@ -943,8 +930,6 @@ impl Instruction {
943930

944931
/// What effect this instruction has on the stack
945932
///
946-
/// TODO what exactly do the numbers represent?
947-
///
948933
/// # Examples
949934
///
950935
/// ```
@@ -1229,7 +1214,6 @@ impl<C: Constant> fmt::Debug for CodeObject<C> {
12291214
}
12301215

12311216
/// A frozen module. Holds a code object and whether it is part of a package
1232-
/// TODO example
12331217
#[derive(Serialize, Deserialize, Debug)]
12341218
pub struct FrozenModule<C: Constant = ConstantData> {
12351219
#[serde(bound(

0 commit comments

Comments
 (0)